Skip to content

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Apr 19, 2024

@ericstj ericstj requested a review from a team as a code owner April 19, 2024 23:26
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 19, 2024
@ericstj
Copy link
Member Author

ericstj commented Apr 22, 2024

Might need another update somewhere.

Error processing binary log file: Unsupported log file format. Latest supported version is 17, the log file has version 18.

To account for newer binlog versions emitted by build tools.
@rainersigwald
Copy link
Member

Might need another update somewhere.

Error processing binary log file: Unsupported log file format. Latest supported version is 17, the log file has version 18.

Tried to update to latest which wasn't on our feeds, so I tried to push it to the feeds but failed, so I backed it down to the latest in the feeds, which should be new enough.

@jaredpar
Copy link
Member

The CI test failures are expected and not fixable.

@jaredpar
Copy link
Member

@marcpopMSFT are you good on the .NET SDK to absorb this in 8.0.1xx if we merge here?

@marcpopMSFT
Copy link
Member

Yes, the 8.0.1xx sdk should take this codeflow for a June release.

@jaredpar jaredpar merged commit 4d7b1fd into dotnet:release/dev17.8 Apr 24, 2024
lambdageek added a commit to dotnet/hotreload-utils that referenced this pull request Apr 29, 2024
Matches dotnet/roslyn#73113

Add a reference to NuGet.Frameworks (but don't bundle our own version) to the generator and the EnC tests.
dotnet-maestro bot added a commit to dotnet/hotreload-utils that referenced this pull request Apr 29, 2024
[release/8.0] Update dependencies from dotnet/roslyn


 - Bump MSBuild dependency to 17.3.4

Matches dotnet/roslyn#73113

Add a reference to NuGet.Frameworks (but don't bundle our own version) to the generator and the EnC tests.

 - add correct feed for MSBuild packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants