EnC: Fix emit for anonymous indexed delegates #70501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
|
@davidwengier @dotnet/roslyn-compiler @cston @jjonescz ptal |
3 tasks
davidwengier
approved these changes
Oct 22, 2023
src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/SymbolMatcherTests.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Oct 23, 2023
cston
reviewed
Oct 23, 2023
cston
reviewed
Oct 23, 2023
cston
reviewed
Oct 23, 2023
...p/Portable/Symbols/AnonymousTypes/SynthesizedSymbols/AnonymousType.DelegateTemplateSymbol.cs
Show resolved
Hide resolved
cston
approved these changes
Oct 23, 2023
jjonescz
reviewed
Oct 24, 2023
src/Compilers/CSharp/Portable/Emitter/EditAndContinue/PEDeltaAssemblyBuilder.cs
Show resolved
Hide resolved
jjonescz
approved these changes
Oct 25, 2023
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes emit error ERR_EncUpdateFailedDelegateTypeChanged and implements the same approach to indexed synthesized delegate templates as we have had for anonymous type templates.
The IDE reports rude edit when a lambda signature changes, so the compiler doesn't need to report ERR_EncUpdateFailedDelegateTypeChanged for that case.
Fixes #67243