Reduce work done in operator overload syntax classifier. #69866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows up as 15% of CPU in the code analysis process in a profile provided by DavidW where semantic token requests are performing poorly. Roslyn classification walks down the tree, finding AssignmentExpressionSyntax nodes and performing semantic binding on the nodes (expensive). Two optimizations to short-circuit before performing the binding: 1) Per Cyrus, this operation doesn't need to occur on simple assignments (the most common case of AssignmentExpressionSyntax nodes) 2) Check whether the requested range intersects the location where the classification would actually be reported.
ghost
added
Area-IDE
untriaged
Contributor
Author
|
|
...aces/CSharp/Portable/Classification/SyntaxClassification/OperatorOverloadSyntaxClassifier.cs
Show resolved
Hide resolved
...aces/CSharp/Portable/Classification/SyntaxClassification/OperatorOverloadSyntaxClassifier.cs
Outdated
Show resolved
Hide resolved
...VisualBasic/Portable/Classification/SyntaxClassification/OperatorOverloadSyntaxClassifier.vb
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Sep 8, 2023
genlu
approved these changes
Sep 8, 2023
| Dim symbolInfo = semanticModel.GetSymbolInfo(syntax, cancellationToken) | ||
| If TypeOf symbolInfo.Symbol Is IMethodSymbol AndAlso | ||
| DirectCast(symbolInfo.Symbol, IMethodSymbol).MethodKind = MethodKind.UserDefinedOperator Then | ||
| If (operatorSpan.IsEmpty OrElse Not operatorSpan.IntersectsWith(textSpan)) Then |
Member
There was a problem hiding this comment.
Suggested change
| If (operatorSpan.IsEmpty OrElse Not operatorSpan.IntersectsWith(textSpan)) Then | |
| If operatorSpan.IsEmpty OrElse Not operatorSpan.IntersectsWith(textSpan) Then |
Contributor
Author
There was a problem hiding this comment.
Bah, it doesn't look like this change was pushed before merged. Will create a small PR with just that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows up as 15% of CPU in the code analysis process in a profile provided by DavidW where semantic token requests are performing poorly.
Roslyn classification walks down the tree, finding AssignmentExpressionSyntax nodes and performing semantic binding on the nodes (expensive).
Two optimizations to short-circuit before performing the binding: 1) Per Cyrus, this operation doesn't need to occur on simple assignments (the most common case of AssignmentExpressionSyntax nodes) 2) Check whether the requested range intersects the location where the classification would actually be reported.