Skip to content

Fix 'use compound coalesce' analyzer in the presence of pp directives #69851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix 'use compound coalesce' analyzer in the presence of pp directives #69851

merged 1 commit into from
Sep 7, 2023

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Sep 7, 2023

Fixes #69783

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner September 7, 2023 20:37
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 7, 2023
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Sep 7, 2023

@genlu @akhera99 Thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit e6da0af into dotnet:main Sep 7, 2023
@ghost ghost added this to the Next milestone Sep 7, 2023
@CyrusNajmabadi CyrusNajmabadi deleted the useCompoundPP branch September 12, 2023 17:51
@allisonchou allisonchou mentioned this pull request Sep 12, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhera99 akhera99 akhera99 approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.8 P3

Development

Successfully merging this pull request may close these issues.

[BUG] The IDE0022 analyzer mistakenly suggests/fixes code that includes preprocessor directives

3 participants

@CyrusNajmabadi @akhera99 @Cosifne