Properly support (and reject) a limited set of preprocessor directive scenarios for 'use expression body'. #69849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Sep 7, 2023
| out SyntaxToken semicolonToken) | ||
| { | ||
| return TryConvertToExpressionBodyForBaseProperty(declaration, conversionPreference, out arrowExpression, out semicolonToken); | ||
| return TryConvertToExpressionBodyForBaseProperty(declaration, conversionPreference, cancellationToken, out arrowExpression, out semicolonToken); |
Member
Author
There was a problem hiding this comment.
most changes are passing a CT along.
CyrusNajmabadi
commented
Sep 7, 2023
| CancellationToken cancellationToken, | ||
| [NotNullWhen(true)] out ExpressionSyntax? expression, | ||
| out SyntaxToken semicolonToken) | ||
| { |
Member
Author
There was a problem hiding this comment.
meat of hte change is here.
Member
Author
akhera99
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69783