Mark export attributes as Inherited = false #69810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes dotnet#69809 These attributes are used to mark MEF exported provider types for various extensions into Roslyn, and not designed to be inherited by the sub-types. dotnet/roslyn-analyzers#6903 tracks adding a meta-analyzer that will flag these attributes applied to abstract types.
ghost
added
Area-Analyzers
untriaged
Member
|
@mavasani Just to confirm, even though this is something that was inherited from the perspective of .NET, it never actually worked? So this isn't changing user behavior in some way, even if somebody somehow succeeded in making this work? |
Contributor
Author
Yes, exactly. |
genlu
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69809
These attributes are used to mark MEF exported provider types for various extensions into Roslyn, and not designed to be inherited by the sub-types. dotnet/roslyn-analyzers#6903 tracks adding a meta-analyzer that will flag these attributes applied to abstract types.