Use optimized hash creation methods on .NET 5+ #67999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
sharwell
force-pushed
the
incremental-hash-2
branch
from
bb641e1 to
d086859
Compare
src/Workspaces/Core/Portable/Workspace/Solution/Checksum_Factory.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Apr 27, 2023
This was referenced Apr 27, 2023
sharwell
force-pushed
the
incremental-hash-2
branch
from
d086859 to
48e9cc5
Compare
stephentoub
reviewed
Apr 27, 2023
| return From(hash); | ||
| #elif NET5_0_OR_GREATER | ||
| using var pooledHash = s_incrementalHashPool.GetPooledObject(); | ||
| Span<byte> buffer = stackalloc byte[SharedPools.ByteBufferSize]; |
Member
There was a problem hiding this comment.
4K is a much larger buffer than we typically like to stackalloc. It might be fine for your scenarios, just calling it out. We have a rough guideline of not stackalloc'ing more than 1K.
Member
There was a problem hiding this comment.
(Also, keep in mind this whole buffer will be zero'd unless you're using SkipLocalsInit.)
Member
Glad it was helpful. Curious what the net impact looks like if there are any perf tests that surface it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the changes suggested in #67995 (comment)
Review commit-by-commit highly recommended.
Supersedes #67998
Fixes #67995