Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link isexternalinit to avoid errors in O# about missing reference #67106

Merged
merged 1 commit into from
Mar 1, 2023
Merged

link isexternalinit to avoid errors in O# about missing reference #67106

merged 1 commit into from
Mar 1, 2023

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Feb 28, 2023 •
edited
Loading

O# build fails when upgrading to newer roslyn packages with

OmniSharpLineFormattingOptionsProvider.cs(27,17): error CS7069: Reference to type 'IsExternalInit' claims it is defined in 'Microsoft.CodeAnalysis.Workspaces', but it could not be found

This change appears to fix the problem

@dibarbet dibarbet requested a review from tmat February 28, 2023 21:12
@dibarbet dibarbet merged commit 2b95254 into dotnet:main Mar 1, 2023
@ghost ghost added this to the Next milestone Mar 1, 2023
@RikkiGibson RikkiGibson modified the milestones: Next, 17.6 P2 Mar 2, 2023
@dibarbet dibarbet mentioned this pull request Mar 2, 2023
Merged
@allisonchou allisonchou mentioned this pull request Mar 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

@sharwell sharwell sharwell approved these changes

@333fred 333fred 333fred approved these changes

@JoeRobich JoeRobich Awaiting requested review from JoeRobich

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.6 P2
Development

Successfully merging this pull request may close these issues.
5 participants
@dibarbet @tmat @sharwell @333fred @RikkiGibson