Make bootstrap failures easier to debug #63236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before bootstrap failures would occur in a target after `CoreCompile`. These failures were then repeated for all subsequent `Compilation` events that occurred after. In certain cases it made it hard to track down which compile event actually hit the error. Now it's very straight forward. This has the added bonus that the build fails fast when this happens vs. continuing on and making the log files even bigger.
Member
Author
|
@dotnet/roslyn-compiler PTAL. Making bootstrap failures easier to debug by failing compilation fast when possible. |
333fred
approved these changes
Aug 5, 2022
Member
333fred
left a comment
333fred
left a comment
There was a problem hiding this comment.
LGTM (commit 2). I think it would also be good to check in a small doc to docs/Compilers about how you see this log.
Member
Author
That is a good idea. I will work on that. |
333fred
reviewed
Aug 8, 2022
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| #if !BOOTSTRAP | ||
| #if BOOTSTRAP |
RikkiGibson
approved these changes
Aug 8, 2022
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before bootstrap failures would occur in a target after
CoreCompile.These failures were then repeated for all subsequent
Compilationevents that occurred after. In certain cases it made it hard to track
down which compile event actually hit the error. Now it's very straight
forward.
This has the added bonus that the build fails fast when this happens vs.
continuing on and making the log files even bigger.