Handle nullable annotations on user defined operators and conversions #59169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a VisitOperandsHonoringAnnotations that will split the state if needed based on annotations - Call it from user defined conversions and binary operators - Add tests
…ions' into nullable-conv-annotations
ghost
added
the
RikkiGibson
force-pushed
the
nullable-conv-annotations
branch
from
d81bf7f to
ecfe673
Compare
cston
reviewed
Feb 2, 2022
Do we need Refers to: src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs:8771 in ecfe673. [](commit_id = ecfe673, deletion_comment = False) |
Co-authored-by: Charles Stoner <10732005+cston@users.noreply.github.com>
cston
approved these changes
Feb 2, 2022
|
I couldn't think of ways that the conditional state from the VisitOptionalImplicitConversion would be meaningfully used at either of those locations, so I added the Unsplit() call to be "conservative" about it. |
chsienki
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34556 (replacing an old PR)
Closes #32671
Closes #49575