Skip to content

Remove dependency on options from IDiagnosticService #59096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2022
Merged

Remove dependency on options from IDiagnosticService #59096

merged 2 commits into from
Feb 3, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Jan 27, 2022

Add TypeScript external access for IDiagnosticService

@tmat tmat requested a review from a team as a code owner January 27, 2022 02:00
@ghost ghost added the Area-IDE label Jan 27, 2022
@runfoapp runfoapp bot mentioned this pull request Jan 27, 2022
Closed
@runfoapp runfoapp bot mentioned this pull request Jan 31, 2022
Closed
@runfoapp runfoapp bot mentioned this pull request Feb 1, 2022
Closed
@tmat
Copy link
Member Author

tmat commented Feb 3, 2022

@dibarbet

@tmat tmat merged commit 96b3e1d into dotnet:main Feb 3, 2022
@ghost ghost added this to the Next milestone Feb 3, 2022
@tmat tmat deleted the PullDiag branch February 3, 2022 04:01
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dibarbet dibarbet dibarbet approved these changes

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

17.2.P1

Development

Successfully merging this pull request may close these issues.

3 participants

@tmat @dibarbet @RikkiGibson