Move off of the legacy IVsPackageInstallerServices.IsPackageInstalled API. #53399
Conversation
| } | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| private bool IsPackageInstalled(ProjectId projectId, string packageName) | ||
| { | ||
| var cancellationToken = CancellationToken.None; |
There was a problem hiding this comment.
we coudl consdier actually making this codepath cancellable with a TWD. but that felt out of scope here (And isn't something we supported prior to this either).
|
I have manually validated all the scenairos (including undo/redo). Everythign seems to be working properly. There's an open case that we should have install/uninstall use a TWD, but we've lived without that for now, so i'm fine not changing that here. |
| cancellationToken.ThrowIfCancellationRequested(); | ||
| await ProcessProjectChangeAsync(nugetService, solution, projectId, cancellationToken).ConfigureAwait(false); | ||
| } | ||
| return await doWorkAsync(nugetService).ConfigureAwait(false); |
There was a problem hiding this comment.
would it be reasonable here to make the function just take in a cancellation token? To avoid any chance that the cancellation token in dowork is different from the one passed into PerformNuGetProjectServiceWorkAsync
There was a problem hiding this comment.
sure, that woudl be reasonable :)
src/VisualStudio/Core/Def/Packaging/PackageInstallerServiceFactory.cs
Outdated
Show resolved
Hide resolved
ghost
added this to the 
Nuget has no plans to provide a more moden equivalent. The recommendation is to just use GetInstalledPackagesAsync and check the value of that. So that's what this PR does :)
Should be viewed with whitespace diff off.