Disable NuGet restore within Visual Studio

[sharwell]

The in-IDE restore operation does not produce bitwise identical results to the command line Restore.cmd script, which results in unavoidable performance degradations during daily developer scenarios such as branch switches and merges. This change disables the IDE restore operation, so all experiences rely on the Restore.cmd script for uniform behavior.

Unblocks #44034
See dotnet/arcade#5172

[jasonmalinowski]

@sharwell The bug you're tagging in dotnet/arcade is already closed -- does that mean the underlying bug is fixed? If so, can we consume that fix? If not, do we have a bug on the appropriate team to investigate?

[sharwell]

@jasonmalinowski We don't use that version of arcade. Even if we did, arcade continues to deviate further from what Visual Studio does so today it still would not fix all cases. It appears that dotnet/arcade is generally incompatible with NuGet restore inside Visual Studio.

[jasonmalinowski]

We don't use that version of arcade.

Why not?

It appears that dotnet/arcade is generally incompatible with NuGet restore inside Visual Studio.

Let's get the bugs filed then; we shouldn't be having to disable this long term.

[sharwell]

Why not?

@tmat?

Let's get the bugs filed then ...

Filed dotnet/arcade#5550

[tmat]

Why not?

Do you meant that Roslyn is on 1.x reversion vs 5.x which is Arcade master? If so, any fix i Arcade master can (should) be ported to Arcade release/3.x branch (1.x version).

[sharwell]

Ping @tmat for review

[tmat]

Need to be clear this is a workaround and have a plan how to remove it.

[sharwell]

@tmat I believe I can work around this issue by disabling NuGet as a local IDE setting. We only need to merge this if one of the following two things occurs:

1. We want to merge always restore project in build #44034
2. Other people are complaining about IDE stability when restore is enabled

[RikkiGibson]

Could you please share where to find the IDE setting that disables implicit NuGet restore?