Fix converted nullability on extract method #39134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t would cause incorrect behavior for casting of object to another type. Make sure to get type info of the cast expression, not the expression type
ryzngard
added
Area-IDE
New Language Feature - Nullable Reference Types
jasonmalinowski
approved these changes
Oct 8, 2019
| void M() | ||
| { | ||
| object? o = null; | ||
| var s = [|(string?)o|]; |
There was a problem hiding this comment.
Did we also want a test for the explicit case where this cast is just (string)? It's invalid code but the compiler supposedly maintains the flow state and will consider s to still be string?.
There was a problem hiding this comment.
Added more tests. Please confirm they are the behavior we want :)
src/Features/CSharp/Portable/ExtractMethod/CSharpSelectionResult.ExpressionResult.cs
Outdated
Show resolved
Hide resolved
allisonchou
added a commit
to allisonchou/roslyn
that referenced
this pull request
Nov 2, 2019
This reverts commit ba47b2f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39075