Fix Microbuild parameters #29588
Merged
Fix Microbuild parameters #29588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
force-pushed
the
MicrobuildFIx
branch
2 times, most recently
from
842196f to
83511cf
Compare
|
@jasonmalinowski @jaredpar A few more fixes to generate the correct package versions in official builds. |
|
@jmarolf PTAL |
jmarolf
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
-cibuildin scripts now translates to/p:ContinuousIntegrationBuild=truein targets files,-officialtranslates to/p:OfficialBuildId=$(BUILD_BUILDNUMBER). Previously,-cibuildmeant Jenkins, not an official CI build.Also copy Roslyn CoreXT packages to
DevDivPackages\Roslyndirectory instead ofInsertiondirectory. The former is uploaded to CoreXT store, the latter is uploaded to VSTS store, where we upload Willow VSIXes. Prior PR #29408 we copied them to both places.