Fix and clean up NuGet package publishing #29562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaredpar @dotnet/roslyn-infrastructure PTAL |
| if ($kind -ne "PerBuildPreRelease") { | ||
| throw "Branches are only allowed to publish PerBuildPreRelease" | ||
| foreach ($nugetKind in $publishData.nugetKind) { | ||
| if ($kind -ne "PerBuildPreRelease" -and $kind -ne "Shipping" -and $kind -ne "NonShipping") { |
There was a problem hiding this comment.
Not going to block this, but I admit the terminology here is confusing -- I assume "nonshipping" is one with a preview tag but not a per-build tag?
There was a problem hiding this comment.
NonShipping/NonShipping is not about the version suffix.
It's about where we deploy the packages. Shipping means shipping on nuget.org. NonShipping means not shipping on nuget.org
There was a problem hiding this comment.
Here we want to publish all Shipping and NonShipping to myget.
There was a problem hiding this comment.
$kind needs to be renamed to $nugetKind
jasonmalinowski
approved these changes
Aug 28, 2018
|
test ubuntu_16_debug_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #29408 changed the layout of NuGet output directories but did not update publishing script and data accordingly.