Do not publish in tests.sh #23398
Merged
Do not publish in tests.sh #23398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
reviewed
Nov 27, 2017
| { | ||
| directory = Path.GetDirectoryName(directory); | ||
| } | ||
| return directory == null ? null : path; |
There was a problem hiding this comment.
In the case of directory == null we should throw an exception. Everything is busted at that point. Should have a declarative error message stating what went wrong.
|
(Waiting for #23405 to go in, then going to heavily refactor this PR) |
It's gross, but we need to publish *something* until ILAsm is exposed as a normal assembly
jaredpar
approved these changes
Nov 28, 2017
| else | ||
| { | ||
| ilasmExeName = "ilasm"; | ||
| } |
There was a problem hiding this comment.
Consider using a conditional operator here.
|
retest windows_release_unit32_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILAsm is the only asset needed, so put that in CoreToolset
Ping @jaredpar
Note that CoreToolset is currently publishing into
Binaries/Toolsdirectly. This makes sense for the binary paths (Binaries/Tools/ilasm), but it clutters the Tools directory immensely (lots of dlls, e.g.System.IO.Pipes.dll)I also synced the location of
dotnetto be the same as the place where the windows build installs it, which isBinaries/Tools/dotnetI also tried running
dotnet-xunit.dlldirectly out ofBinaries/Toolsinstead of digging into.nuget, but that was giving super weird errors, so I left that for a later time.Also note that #23316 would be super nice to have here, but that PR has super absurd errors, so that can go in separately.