Create build.sh #23180
Merged
Create build.sh #23180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest windows_release_unit32_prtest please |
agocke
reviewed
Nov 15, 2017
| # Note that while ~ usually refers to $HOME, in the case where $HOME is unset, | ||
| # it looks up the current user's home dir, which is what we want. | ||
| # https://www.gnu.org/software/bash/manual/html_node/Tilde-Expansion.html | ||
| export HOME=$(cd ~ && pwd) |
There was a problem hiding this comment.
think this is required for mac builds.
|
test mac please |
jaredpar
approved these changes
Nov 16, 2017
|
Well, that mac test exploded pretty hard: The reason it's not needed anymore is because that code is duplicated in |
|
test mac please |
|
Mac test "passed": CI has been broken for a while, it's just that no tests ran, and so jenkins freaks out and reports a failure (even though everything executed normally). (this was happening before this PR, so this PR should be okay to merge. We should probably fix that, though...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface is a rough parallel to
build.cmd. Note that this script will be compatible with the repo API going forward, and so minor changes may happen to make sure it's exactly aligned with the repo toolset - also note that this PR doesn't try to be 100% compatible with the repo API, it's just a starting point, because the linux story is painful right now and I can't stand it anymore 😛.The biggest win here, in my opinion, is less telling users to run things in
./build/scripts, which IMO should be an internal-only directory (nobody should ever run scripts directly from there).(
obtain_dotnet.shis in there, but hey, one step at a time 😊)ping @jaredpar