Replace Windows RID multitargeting with singular form #23161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
approved these changes
Nov 14, 2017
khyperia
force-pushed
the
rid_single_target
branch
from
f757827 to
b98e2ca
Compare
khyperia
force-pushed
the
rid_single_target
branch
from
b98e2ca to
c90a892
Compare
jaredpar
reviewed
Nov 14, 2017
| @@ -10,7 +10,7 @@ | |||
| <RootNamespace>Roslyn.InteractiveHost.UnitTests</RootNamespace> | |||
| <AssemblyName>Roslyn.InteractiveHost.UnitTests</AssemblyName> | |||
| <TargetFramework>net461</TargetFramework> | |||
| <RuntimeIdentifier>win-x86</RuntimeIdentifier> | |||
| <RuntimeIdentifier>$(RoslynDesktopRuntimeIdentifierX86)</RuntimeIdentifier> | |||
There was a problem hiding this comment.
Ah. Well that solves the mystery of why we were keeping those x86 monikers around.
|
|
retest ubuntu_14_debug_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension to #23113 (wanted to keep changes minimal/separate).
This un-plural-izes
RoslynDesktopRuntimeIdentifieras well as all theRuntimeIdentifierproperties in windows-only projects. Hopefully this has a perf gain, but that isn't the point here (the point is simplification).Ping @jaredpar