Disable unboxing and generic conversions to/from ref-like types #22357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocke
changed the title
|
cc @jcouv for ask mode approval |
jaredpar
reviewed
Oct 2, 2017
| { | ||
| switch (s) | ||
| { | ||
| case Span<object> span: |
There was a problem hiding this comment.
What about an identity case? Dont see that tested in this PR but seems like it would be valid
There was a problem hiding this comment.
It should be valid and I'll add a test for it.
gafter
approved these changes
Oct 2, 2017
jaredpar
approved these changes
Oct 2, 2017
agocke
force-pushed
the
ref-readonly-tests
branch
from
2964476 to
352e3c2
Compare
|
@jaredpar I presumed that your approval was both ask mode and PR approval. Was that correct? |
|
Correct |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Oct 5, 2017
* dotnet/master: (33 commits) Test dumper change to include Isimplicit/Language and some formatting change (dotnet#22309) Add regression tests for fixed local function crashes (dotnet#22470) Use error=true in Obsolete attribute on IsByRefLikeAttribute for ref struct (dotnet#22492) Add tests with ref readonly and ref assemblies (dotnet#22419) Add test for sequence point issue with local function and conditional (dotnet#22499) Keep ProjectState._documentStates sorted rather than resorting the IDs Throttle NFW watson. (dotnet#22483) Suggest "in" for argument positions in IDE (dotnet#22480) Disable unboxing and generic conversions to/from ref-like types (dotnet#22357) Hold DocumentIds in ProjectState in ImmutableLists Fix bug in build-utils Ensure-SdkInPathAndData Add additional tests around Span escaping (dotnet#22413) Turn on the compiler server by default for the compiler VSIX (dotnet#22473) add 64bit detect code to razor remote host client (dotnet#22432) Fix a bug in escape analysis related to 'in' arguments (dotnet#22457) Ref must come before 'partial' in a 'ref partial struct' (dotnet#22403) Address PR feedback Ensure partial method implementation is completed when needed (dotnet#22414) Remove PROTOTYPE markers from "private protected" feature (dotnet#22407) added IVariableDeclarationStatement back to for loop's before condition (dotnet#22358) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no conversion between ref like types and either object or generic parameters (even if constrained to struct) in either direction. This change enforces that rule and adds tests around pattern matching, which exercises this rule.