Bring Compilers.sln into sync with Roslyn.sln #13075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like a couple of changes brought them out of sync and VS really dislikes it.
|
Thanks! |
|
@jasonmalinowski There's a weird ETA failure that I think is unrelated to my change. Would you like someone to look at it or should I just file a bug? |
|
retest windows_eta_open_prtest please |
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <PropertyGroup Label="Globals"> | |||
| <ProjectGuid>c1930979-c824-496b-a630-70f5369a636f</ProjectGuid> | |||
There was a problem hiding this comment.
It looks like this GUID is still being used in Roslyn.sln and CrossPlatform.sln. The fix might be to update the Compiler.sln version instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a couple of changes brought them out of sync
and VS really dislikes it.
/cc @dotnet/roslyn