`OpenProjectAsync` logger's parameter is unused (public API)

[Youssef1313]

MSBuildWorkspace.OpenProjectAsync has a public overload with a logger parameter, which gets passed to MSBuildProjectLoader that is then not using it.

roslyn/src/Workspaces/Core/MSBuild/MSBuild/MSBuildProjectLoader.cs

Lines 160 to 162 in 3472dcb

	#pragma warning disable IDE0060 // TODO: decide what to do with this unusued ILogger, since we can't reliabily use it if we're sending builds out of proc
	ILogger? msbuildLogger = null,
	#pragma warning restore IDE0060

[Youssef1313]

Related to #70469

cc @jasonmalinowski

[Youssef1313]

Trying 4.9.0-1.final which is before #70469, it also doesn't work. But instead of doing nothing, it crashes:

Unhandled exception. Microsoft.Build.Framework.LoggerException: Failed to write to log file "BINLOG_PATH". The process cannot access the file 'BINLOG_PATH'

[jasonmalinowski]

@Youssef1313 That does't look like something that'd be our problem?

[Youssef1313]

@jasonmalinowski Things work properly on 4.8.0

And 4.9.0-1.final crashes, and 4.9.0-3.final does nothing as the parameter is unused.

The same exception was also reported in #70674.

But anyways, 4.9.0-1.final isn't important as it's from the past. What would be needed here is supporting the logger parameter back.