-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Closed
Labels
Area-IDEConcept-Continuous Improvementhelp wantedThe issue is "up for grabs" - add a comment if you are interested in working on itThe issue is "up for grabs" - add a comment if you are interested in working on it
Milestone
Description
public static WorkspaceRegistration GetWorkspaceRegistration(SourceTextContainer? textContainer) | |
{ | |
if (textContainer == null) | |
{ | |
throw new ArgumentNullException(nameof(textContainer)); | |
} |
roslyn/src/Features/LanguageServer/Protocol/Extensions/ProtocolConversions.cs
Lines 144 to 147 in 6be7f04
public static Uri GetUriFromFilePath(string? filePath) | |
{ | |
if (filePath is null) | |
throw new ArgumentNullException(nameof(filePath)); |
cc @genlu @dibarbet @CyrusNajmabadi
It seems like if the parameter type allows null, then the parameter should not be null checked.
Metadata
Metadata
Assignees
Labels
Area-IDEConcept-Continuous Improvementhelp wantedThe issue is "up for grabs" - add a comment if you are interested in working on itThe issue is "up for grabs" - add a comment if you are interested in working on it