Skip to content

Handle satellite assemblies in analyzer loader #56708

@RikkiGibson

Description

@RikkiGibson

I observed that msbuild has special handling for satellite assemblies in their assembly loader:

https://github.com/dotnet/msbuild/blob/c144bfc4693abfd02803fbb8cd223c7b314b9ab3/src/Shared/MSBuildLoadContext.cs#L51-L53

Does Roslyn need to do the same when loading analyzers with localized resources? (fwiw, it does seem like the strategy of preferring assemblies in the same directory, then searching the entire set of provided assemblies, will work around the issue for us, but perhaps a satellite assembly test is missing.)

Also, the requirement that all analyzer dependencies be included in the same directory might also apply to satellite assemblies, which means that shipping the satellite assemblies in a nested folder is technically not supported.

Metadata

Metadata

Assignees

Labels

Area-CompilersBugTenet-GlobalizationA feature does not work properly in a given locale or does not respect locale settings.untriagedIssues and PRs which have not yet been triaged by a lead

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions