-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Description
Most rude edits say something like "Changing xyz will prevent the debug session from continuing".
This is not accurate in Hot Reload scenarios - especially not in Ctlr+F5 since there is no debug session.
Proposal
Split the rude edit message into two parts and compose the two resource strings when reporting the diagnostics based on context:
- description of the edit being made
- why the edit is not allowed
a) The current message when performing EnC: "will prevent the debug session from continuing" ->"requires restarting the debugging session""requires restarting the application"
b) When the capabilities of the runtime do not allow the edit: "... because it is not supported by the runtime"
c) Hot Reload edit: "requires restarting the application"
Examples:
"Updating a generic method requires restarting the application because it is not supported by the runtime"
"Updating a generic method is not supported by the runtime and requires restarting the debugging session"
"Updating a generic method requires restarting the application"
"Updating a generic method requires restarting the debugging session"
UPDATE:
For simplicity, we'll have the same error message for debugging session and Hot Reload.