Breaking API Change

[tannergooding]

PR #4169 Makes a breaking change to the Public API as part of the Toolset Update. Specifically it removes the following from src\Compiles\VisualBasic\Portable\PublicAPI.txt:

• Microsoft.CodeAnalysis.VisualBasic.VisualBasicCommandLineParser.New(isInteractive As Boolean = False) -> Void
• Overrides Microsoft.CodeAnalysis.VisualBasic.VisualBasicCommandLineParser.RegularFileExtension() -> String
• Overrides Microsoft.CodeAnalysis.VisualBasic.VisualBasicCommandLineParser.ScriptFileExtension() -> String

A decision will need to be made on whether or not we need to keep this breaking change or if we should take on the public API increases that will be required to revert it.

[tannergooding]

FYI. @jaredpar, @AnthonyDGreen

[davkean]

Removal of overrides shouldn't be a breaking change (and we're shouldn't log them in PublicAPI.txt). Removal of the constructor is a breaking change.

[sharwell]

Removal of overrides shouldn't be a breaking change (and we're shouldn't log them in PublicAPI.txt).

It is a breaking change if the override has default argument values which differ from those in the base definition. This doesn't apply to the case above but it's something to be aware of before suppressing overrides from the public API.

[jaredpar]

@davkean @sharwell

Yes it's not new public API but it is a part of the overall public API surface. The analyzer defaulted to extra verbosity here. Removal of this alone wouldn't constitute a breaking change.

[davkean]

It is a breaking change if the override has default argument values which differ from those in the base definition. This doesn't apply to the case above but it's something to be aware of before suppressing overrides from the public API.

Technically yes. Would we ever do this - no. And it would result in different behavior between C# and VB (C# calls the base method, VB calls the override).

[gafter]

Fixed in #4186 (documented the breaking change)