Skip to content

Commit

Permalink
Use all RIDs on all platforms
Browse files Browse the repository at this point in the history
  • Loading branch information
khyperia committed Nov 10, 2017
1 parent ac652b5 commit d902abb
Showing 1 changed file with 11 additions and 14 deletions.
25 changes: 11 additions & 14 deletions build/Targets/Settings.props
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@
<RoslynDiagnosticsPropsFilePath>$(NuGetPackageRoot)/microsoft.net.roslyndiagnostics/$(RoslynDiagnosticsNugetPackageVersion)/build/Microsoft.Net.RoslynDiagnostics.props</RoslynDiagnosticsPropsFilePath>
<RoslynPortableTargetFrameworks>net461;netcoreapp2.0</RoslynPortableTargetFrameworks>
<RoslynPortableTargetFrameworks46>net46;netcoreapp2.0</RoslynPortableTargetFrameworks46>
<RoslynPortableRuntimeIdentifiers>win7;win7-x64</RoslynPortableRuntimeIdentifiers>

<RoslynPortableRuntimeIdentifiers>win7;win7-x64;linux-x64;osx-x64</RoslynPortableRuntimeIdentifiers>
<UseSharedCompilation>true</UseSharedCompilation>

<UsingToolPdbConverter>true</UsingToolPdbConverter>
<Features>strict, IOperation</Features>
<ProduceReferenceAssembly>true</ProduceReferenceAssembly>
Expand Down Expand Up @@ -106,21 +107,25 @@

<!-- https://github.com/dotnet/roslyn/issues/21272 -->
<GenerateResourceMSBuildRuntime Condition="'$(TargetFramework)' == 'netcoreapp2.0'">CurrentRuntime</GenerateResourceMSBuildRuntime>
<!--

<!--
Official build:
- Build standalone Portable PDBs to reduce the size of the binaries.
- Convert Portable PDBs to Windows PDBs and publish the converted PDBs to Symbol Store to allow WinDBG,
Watson and other tools to find symbol format they understand.
Jenkins build:
- Embed PDBs to make it easier to debug Jenkins crash dumps.
Developer build:
- Embed PDBs to be consistent with Jenkins builds.
Cross-platform (developer + Jenkins) build:
- Use Portable PDBs.
-->
<RoslynDebugType Condition="'$(OfficialBuild)' == 'true'">portable</RoslynDebugType>
<RoslynDebugType Condition="'$(OfficialBuild)' != 'true'">embedded</RoslynDebugType>
<RoslynDebugType Condition="'$(OS)' != 'Windows_NT'">portable</RoslynDebugType>

<!--
The source root path used for deterministic normalization of source paths.
Expand All @@ -141,8 +146,6 @@

<!-- Windows specific settings -->
<PropertyGroup Condition="'$(OS)' == 'Windows_NT'">
<BaseNuGetRuntimeIdentifier>win7</BaseNuGetRuntimeIdentifier>
<UseSharedCompilation>true</UseSharedCompilation>

<!-- Presently our code can build on machines with Dev14 or Dev15 but only successfully deploy
in the Dev15 environment. -->
Expand All @@ -155,12 +158,6 @@
<VisualStudioBuildToolsVersion Condition="'$(IsDev14VsiBuild)' == 'true'">14.3.25420</VisualStudioBuildToolsVersion>
</PropertyGroup>

<!-- Unix specific settings -->
<PropertyGroup Condition="'$(OS)' != 'Windows_NT'">
<RoslynDebugType>portable</RoslynDebugType>
<RoslynPortableRuntimeIdentifiers>linux-x64;osx-x64</RoslynPortableRuntimeIdentifiers>
</PropertyGroup>

<!--
If TargetNetFX20 is true the project targets Framework 2.0 reference assemblies provided by Microsoft.NetFX20 nuget package.
Use the latest Framework toolset to build, but set msbuild properties below
Expand Down

0 comments on commit d902abb

Please sign in to comment.