Use CastUp in VB implementation to improve downstream performance

dotnet · Aug 3, 2024 · 72b1e15 · 72b1e15
1 parent d5ebaf2
commit 72b1e15
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/Compilers/VisualBasic/Portable/Symbols/AssemblySymbol.vb b/src/Compilers/VisualBasic/Portable/Symbols/AssemblySymbol.vb
@@ -764,7 +764,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Symbols
 
         Private ReadOnly Property IAssemblySymbol_Modules As IEnumerable(Of IModuleSymbol) Implements IAssemblySymbol.Modules
             Get
-                Return Me.Modules
+                Return ImmutableArray(Of IModuleSymbol).CastUp(Me.Modules)
             End Get
         End Property
 

diff --git a/...kspaces/SharedUtilitiesAndExtensions/Compiler/Core/SymbolKey/SymbolKey.ModuleSymbolKey.cs b/...kspaces/SharedUtilitiesAndExtensions/Compiler/Core/SymbolKey/SymbolKey.ModuleSymbolKey.cs
@@ -43,8 +43,7 @@ protected sealed override SymbolKeyResolution Resolve(
                 }
                 else
                 {
-                    // Visual Basic implementation of IAssemblySymbol.Modules relies on covariance of IEnumerable<T>, so
-                    // the preceding concrete type check will fail.
+                    // Otherwise fall back to generic enumeration
                     result.AddValuesIfNotNull(assemblyModules);
                 }
             }