Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check option when try get XamlVersionProps #1444

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Check option when try get XamlVersionProps #1444

merged 3 commits into from
Oct 4, 2024

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented Oct 4, 2024 •
edited
Loading

Should fix https://dev.azure.com/dnceng/internal/_build/results?buildId=2552198&view=logs&j=7ae71e7c-d4fe-51ea-64cd-240849b77ab1&t=e2756d63-0606-58d5-0f0d-91c79a5ba922 with this PR dotnet/roslyn#75348

It seems like

  1. OneOffInsertion.ps1 is not accepting updatexamlroslynversino.
  2. When fetch file from VS, we should check the option.

@Cosifne @RikkiGibson
Update src/RoslynInsertionTool/scripts/OneOffInsertion.ps1
e1b8951 
Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
@Cosifne Cosifne enabled auto-merge October 4, 2024 19:00
@Cosifne Cosifne merged commit 589c37a into dotnet:main Oct 4, 2024
6 checks passed
@Cosifne Cosifne mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cosifne @RikkiGibson