generated from dotnet/new-repo
-
Notifications
You must be signed in to change notification settings - Fork 19
Warn if missing global.json to enforce consistent SDK versions #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MattKotsenas
merged 10 commits into
dotnet:main
from
MattKotsenas:feature/enforce-global-json
Jan 21, 2026
Merged
Warn if missing global.json to enforce consistent SDK versions #73
MattKotsenas
merged 10 commits into
dotnet:main
from
MattKotsenas:feature/enforce-global-json
Jan 21, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattKotsenas
commented
Dec 17, 2025
96d0986 to
9c28708
Compare
Member
Author
|
For posterity, reviewed and signed off offline by @baronfel. |
This was referenced Jan 22, 2026
Bump DotNet.ReproducibleBuilds from 1.2.39 to 2.0.1
MarkCiliaVincenti/ResilientSaveChanges.EFCore#27
Open
This was referenced Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
Add new warning
RPB0003to enforceglobal.jsonand setting an SDK version. This prevents the SDK's automatic behavior of always using the latest installed SDK version, as this often runs afoul of other common practices of setting language and analyzer versions to "latest".Currently, any SDK version and roll forward policy is acceptable. For a total reproducibility perspective, we should enforce roll forward
disable, but currently the dev experience is not great. Oncedotnetupis available we may want to suggest a more restrictive setting.I'm considering this a "breaking change" and bumping the major version accordingly.