Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates/Consolidates the two BDN versions to latest #9009

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Updates/Consolidates the two BDN versions to latest #9009

merged 2 commits into from
Jul 24, 2023

Conversation

maryamariyan
Copy link
Member

@maryamariyan maryamariyan commented Jul 23, 2023 •
edited
Loading

  • Noticed two separate versions of BenchmarkDotNet being used not sure if it's really needed to be different.

Traced down when we originally ended up with both versions on this file, it started here: 108a63c

I think both can be consolidated into one.

@maryamariyan
Updates/Consolidates the two BDN versions to latest
34e4015 
- Noticed two separate versions of BDN being used
@maryamariyan maryamariyan requested review from a team as code owners July 23, 2023 21:25
@maryamariyan maryamariyan self-assigned this Jul 23, 2023
@maryamariyan maryamariyan merged commit 0056494 into main Jul 24, 2023
@maryamariyan maryamariyan deleted the dev/maryamariyan/benchmarkdotnetversion branch July 24, 2023 13:13
@ghost ghost added this to the Next milestone Jul 24, 2023
@allisonchou allisonchou modified the milestones: Next, 17.8 P1 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees

@maryamariyan maryamariyan

Labels
None yet
Projects
None yet
Milestone
17.8 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@maryamariyan @davidwengier @allisonchou