Fix benchmarks to produce correct documents #8072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinCampbell
commented
Jan 4, 2023
| for (var i = 0; i < 4; i++) | ||
| { | ||
| var filePath = Path.Combine(projectRoot, "Views", "Home", $"View00{i % 4}.cshtml"); | ||
| var text = SourceText.From(filePath, encoding: null); |
There was a problem hiding this comment.
🪲 A SourceText is created using the file path as the text.
ryanbrandenburg
approved these changes
Jan 4, 2023
| @@ -1,16 +1,12 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
| // Licensed under the MIT license. See License.txt in the project root for license information. | |||
|
|
|||
| #nullable disable | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change cleans up
ProjectSnapshotManagerBenchmarkBasea bit, which is the base class of several of the tooling benchmarks. While cleaning this up, I was surprised to find a bug where several documents with initialized with a file path as the text, rather than the actual file text. This results in some benchmarks, notablyBackgroundCodeGenerationBenchmark, being completely invalid.