Mark source gen as shipping

[davidwengier]

The latest build has the source gen as the only DLL missing symbols, and I think letting it be marked as a shipping should fix that. And it does ship in the VSIX after all.

Hopefully this can't break anything else 🤷‍♂️

[davidwengier]

@chsienki Do you know of anything this could break? Does it warrant a validation build (though they won't publish symbols, so won't validiate my changes per se)?

[chsienki]

I think it should be ok, because nothing directly relies on this package. The SDK consumes it from the transport so it shouldn't make any difference.

That being said, if we just need symbols for this can we not just turn them on, rather than making this a shipping package? What diff do you see in the binlog between IsShipping=true vs false?

[davidwengier]

A fair question, let me dig in to the arcade bits and see what I can see about more finely tuning things.

[davidwengier]

Okay, looks like IsShippingAssembly should affect only symbol publishing (and xliff tasks but there aren't any xlf files in this project)

[davidwengier]

Forgot to answer this:

What diff do you see in the binlog between IsShipping=true vs false?

Symbol publishing is what is affected by this, but symbols don't get published for builds from non-release branches, so we can't actually test this fully without merging :)

Best we can do is merge, and revert if something goes wrong.

[davidwengier]

@chsienki if you're back for a review, hopefully this might finally fix #6239

[chsienki]

LGTM. Thanks for the digging.