Skip to content

Pin vsce version used in release script #5704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2021
Merged

Conversation

captainsafia
Copy link
Member

Attempting to resolve recent issues with this build step by pinning the vsce version used to a known value.

@captainsafia captainsafia requested a review from a team as a code owner November 5, 2021 23:17
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me if it fixes it!

@ryanbrandenburg
Copy link
Contributor

I suspect the specific behavior pinning protects us from is microsoft/vscode-vsce#628. Another project ran into a similar problem. If the License file IS the issue would it be possible for us to include one in future releases?

@captainsafia
Copy link
Member Author

I suspect the specific behavior pinning protects us from is microsoft/vscode-vsce#628. Another project ran into a similar problem. If the License file IS the issue would it be possible for us to include one in future releases?

Yep. I suppose we can use the MIT license as is done repo-wide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants