Skip to content

Remove TM themes to prevent overcoloring #4250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2021
Merged

Remove TM themes to prevent overcoloring #4250

merged 1 commit into from
Sep 27, 2021

Conversation

ryanbrandenburg
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg commented Sep 24, 2021 •
edited
Loading

Summary of the changes

  • We have proposed a more permanent fix for this against the platform, but due to resource constraints we're going to wait a bit to do that.
  • This prevents "overcoloring" by removing TM themes which are known to cause problems. This degrades the startup experience to improve correctness.

Fixes: https://github.com/dotnet/aspnetcore/issues/36614

NTaylorMullen
NTaylorMullen approved these changes Sep 24, 2021
View reviewed changes
Copy link

@NTaylorMullen NTaylorMullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad day but totally get why we have to do it. :shipit:

@ryanbrandenburg ryanbrandenburg merged commit 083ba76 into main Sep 27, 2021
@ryanbrandenburg ryanbrandenburg deleted the rybrande/TextMateComment branch September 27, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NTaylorMullen NTaylorMullen NTaylorMullen approved these changes

@allisonchou allisonchou Awaiting requested review from allisonchou

@sharwell sharwell Awaiting requested review from sharwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default editor colors let TextMate shine through
2 participants
@ryanbrandenburg @NTaylorMullen