Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions using new (coherent) darc tool #252

Closed
wants to merge 2 commits into from

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Feb 24, 2019

No description provided.

</Dependency>
<Dependency Name="Microsoft.AspNetCore.Testing" Version="3.0.0-preview4.19122.10">
<Dependency Name="Microsoft.AspNetCore.Testing" Version="3.0.0-preview4.19122.13">
<CoherentParentDependency>Microsoft.NETCore.App</CoherentParentDependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this been added only for this dependency and not all dependencies from aspnet/Extensions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't bother to update the ... .Sources dependencies.

@dougbu
Copy link
Member Author

dougbu commented Feb 25, 2019

FYI, despite our questions, the CI checks were successful.

@NTaylorMullen
Copy link
Contributor

What does having a CoherentParentDependency do? If the parent dependency changes the child gets it's version updated too?

@dougbu
Copy link
Member Author

dougbu commented Feb 25, 2019

What does having a CoherentParentDependency do?

It informs a new version of the darc tool that it should ensure the chosen dependencies all have a common transitive dependency. In this case, we're ensuring every dependency (except .Sources packages and tools) shares their Microsoft.NETCore.App versions.

@NTaylorMullen
Copy link
Contributor

It informs a new version of the darc tool that it should ensure the chosen dependencies all have a common transitive dependency. In this case, we're ensuring every dependency (except .Sources packages and tools) shares their Microsoft.NETCore.App versions.

Ahhh gotcha, enforcing coherence 👍

Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does darc add "CoherentParentDependency" items for us or do we have to do it manually?

@dougbu
Copy link
Member Author

dougbu commented Feb 25, 2019

Does darc add "CoherentParentDependency" items for us or do we have to do it manually?

We do it manually. Once this is all in, the docs/ReferenceResolution.md doc in Extensions and AspNetCore to include the attribute in the "adding a new dependency" blurb.

BTW I'm not merging this because I used the wrong syntax.

@dougbu
Copy link
Member Author

dougbu commented Feb 25, 2019

Closing this. I'm going to redo this using the correct syntax and whatever @mmitche comes up with for our second diamond dependencies (w/ Extensions).

@dougbu dougbu closed this Feb 25, 2019
@dougbu dougbu deleted the dougbu/coherent.darc branch February 25, 2019 19:19
chsienki pushed a commit to chsienki/razor-tooling that referenced this pull request Aug 26, 2022
* Update CODEOWNERS to `razor-compiler`

* Update CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants