-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions using new (coherent) darc
tool
#252
Conversation
</Dependency> | ||
<Dependency Name="Microsoft.AspNetCore.Testing" Version="3.0.0-preview4.19122.10"> | ||
<Dependency Name="Microsoft.AspNetCore.Testing" Version="3.0.0-preview4.19122.13"> | ||
<CoherentParentDependency>Microsoft.NETCore.App</CoherentParentDependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why has this been added only for this dependency and not all dependencies from aspnet/Extensions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't bother to update the ... .Sources
dependencies.
FYI, despite our questions, the CI checks were successful. |
What does having a CoherentParentDependency do? If the parent dependency changes the child gets it's version updated too? |
It informs a new version of the |
Ahhh gotcha, enforcing coherence 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does darc add "CoherentParentDependency" items for us or do we have to do it manually?
We do it manually. Once this is all in, the docs/ReferenceResolution.md doc in Extensions and AspNetCore to include the attribute in the "adding a new dependency" blurb. BTW I'm not merging this because I used the wrong syntax. |
Closing this. I'm going to redo this using the correct syntax and whatever @mmitche comes up with for our second diamond dependencies (w/ Extensions). |
* Update CODEOWNERS to `razor-compiler` * Update CODEOWNERS
No description provided.