Skip to content

Revert "Revert "Revert "Default the cohosting option in the generator to on.""" #12318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2025
Merged

Revert "Revert "Revert "Default the cohosting option in the generator to on.""" #12318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...piler/Microsoft.CodeAnalysis.Razor.Compiler/src/SourceGenerators/RazorCohostingOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ internal static class RazorCohostingOptions
/// <summary>
/// True if razor is running in the cohosting mode
/// </summary>
internal static bool UseRazorCohostServer { get; set; } = true;
internal static bool UseRazorCohostServer { get; set; } = false;
}
5 changes: 0 additions & 5 deletions ...Compiler/test/Microsoft.NET.Sdk.Razor.SourceGenerators.Tests/RazorSourceGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Razor.Language.Syntax;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.Test.Utilities;
Expand Down Expand Up @@ -2623,9 +2622,6 @@ public async Task SourceGenerator_DoesNotUpdateSources_WhenSourceGeneratorIsSupp
// start with the generator suppressed (this is the default state in VS)
driver = SetSuppressionState(true);

// Disable co-hosting, this test only applies to non-cohosting scenarios
RazorCohostingOptions.UseRazorCohostServer = false;

// results should be empty, and no recorded steps should have run
using var eventListener = new RazorEventListener();
var result = RunGenerator(compilation!, ref driver).VerifyPageOutput();
Expand Down Expand Up @@ -3468,7 +3464,6 @@ public async Task UseRazorCohostServer_CanOverride_Suppression()
["Component.Razor"] = "<h1>Hello world</h1>",
});
var compilation = await project.GetCompilationAsync();
RazorCohostingOptions.UseRazorCohostServer = false;

// Start with the generator suppressed
var (driver, additionalTexts, optionsProvider) = await GetDriverWithAdditionalTextAndProviderAsync(project, configureGlobalOptions: (o) =>
Expand Down