Improve PooledArrayBuilder<T>.ToArray() and ToArrayAndClear() #12217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of providing separate implementations, `ToArray()` and `ToArrayAndClear()` should just call `ToImmutable()` and `ToImmutableAndClear()` and return the underlying array. This ensures that we get the benefit of returning the builder's array when the capacity matches the count.
ToddGrun
reviewed
Sep 11, 2025
| _ => [_element0, _element1, _element2, _element3] | ||
| }; | ||
| } | ||
| => ImmutableCollectionsMarshal.AsArray(ToImmutable()).AssumeNotNull(); |
Contributor
Member
Author
There was a problem hiding this comment.
It's simpler this way. ImmutableArray<T>.Builder.DrainToImmutable() returns an ImmutableArray<T> -- there's no DrainToArray(). So, we'd have to unwrap the result in ToArray() and then the ToImmutable() methods would need to re-wrap the array. Seems more awkward that way.
chsienki
approved these changes
Sep 11, 2025
davidwengier
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of providing separate implementations,
ToArray()andToArrayAndClear()should just callToImmutable()andToImmutableAndClear()and return the underlying array. This ensures that we get the benefit of returning the builder's array when the capacity matches the count.