Skip to content

Default the cohosting option in the generator to on. #12214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

Default the cohosting option in the generator to on. #12214

merged 2 commits into from
Sep 11, 2025

Conversation

@chsienki
Copy link
Member

@chsienki chsienki commented Sep 10, 2025

Defaults the value of cohosting that the generator reads to on.

This should help with the initialization race, as we now default to an on state, meaning it doesn't matter if Roslyn loads the generator before razor has fully initialized.

The generator will subsequently get turned off by LSP if the user has disabled cohosting.

@chsienki chsienki requested a review from a team as a code owner September 10, 2025 23:08
@chsienki
Copy link
Member Author

chsienki commented Sep 10, 2025

@dotnet/razor-tooling for reviews please.

@chsienki chsienki enabled auto-merge (squash) September 10, 2025 23:18
@chsienki chsienki merged commit c10310b into dotnet:main Sep 11, 2025
11 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Sep 11, 2025
chsienki added a commit that referenced this pull request Sep 12, 2025
@chsienki
Revert "Default the cohosting option in the generator to on. (#12214)"
9303203 
This reverts commit c10310b.
@chsienki chsienki mentioned this pull request Sep 12, 2025
Merged
ToddGrun pushed a commit that referenced this pull request Sep 14, 2025
@chsienki
Revert "Default the cohosting option in the generator to on. (#12214)" (
bde4f70 
#12225)

This reverts commit c10310b.
@davidwengier davidwengier mentioned this pull request Sep 15, 2025
Merged
@dotnet-bot dotnet-bot mentioned this pull request Sep 16, 2025
Closed
@akhera99 akhera99 modified the milestones: Next, 18.0 P1 Sep 22, 2025
chsienki added a commit that referenced this pull request Sep 22, 2025
@chsienki
Revert "Revert "Default the cohosting option in the generator to on. (#…
22355f3 
…12214)…"

This reverts commit bde4f70.
@akhera99 akhera99 modified the milestones: 18.0 P1, 18.0 P2 Sep 23, 2025
github-actions bot pushed a commit that referenced this pull request Sep 25, 2025
@chsienki
Revert "Revert "Default the cohosting option in the generator to on. (#…
fefaf69 
…12214)…"

This reverts commit bde4f70.
chsienki added a commit that referenced this pull request Sep 25, 2025
@chsienki
Revert "Revert "Default the cohosting option in the generator to on. (#…
06c0bfa 
…12214)…" (#12253)

This reverts commit bde4f70.
chsienki added a commit that referenced this pull request Sep 25, 2025
@github-actions @chsienki
Revert "Revert "Default the cohosting option in the generator to on. (#…
6ba3de9 
…12214)…" (#12270)

This reverts commit bde4f70.

Co-authored-by: Chris Sienkiewicz <chsienki@microsoft.com>
@chsienki
Copy link
Member Author

chsienki commented Nov 4, 2025

/backport to release/dev18.3

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Started backporting to release/dev18.3 (link to workflow run)

@github-actions github-actions bot mentioned this pull request Nov 4, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidwengier davidwengier davidwengier approved these changes

@dbreshears dbreshears dbreshears approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.0 P2

Development

Successfully merging this pull request may close these issues.

4 participants

@chsienki @davidwengier @dbreshears @akhera99