Filter CSS024 when caused by C# code in an attribute #12209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were inadvertently rejecting any attribute related diagnostics its seems. Partly because the whitespace before the attribute name was being considered as part of the attribute, and partly because each individual token of the attribute value was being considered. I suspect this broke with FUSE and with the node/token reversal. So that's fun.
DustinCampbell
approved these changes
Sep 10, 2025
Member
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
Remove unused usings 😄
.../src/Microsoft.CodeAnalysis.Razor.Workspaces/Diagnostics/RazorTranslateDiagnosticsService.cs
Outdated
Show resolved
Hide resolved
.../src/Microsoft.CodeAnalysis.Razor.Workspaces/Diagnostics/RazorTranslateDiagnosticsService.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Sep 10, 2025
.../src/Microsoft.CodeAnalysis.Razor.Workspaces/Diagnostics/RazorTranslateDiagnosticsService.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a report on reddit.
We were filtering CSS023 and CSS025 but not CSS024. So there is this. But then everything got more complicated because at some point we regressed things and just filtered all Html diagnostics from Html attributes it seems. Clearly test coverage for this wasn't great, so there is a chance this causes us to report more Html diagnostics and therefore regress things for users, but at least we'll find out and be able to fix them.