Share document symbol endpoint with VS Code #11769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
Apr 24, 2025
...Razor/src/Microsoft.CodeAnalysis.Remote.Razor/DocumentSymbols/RemoteDocumentSymbolService.cs
Outdated
Show resolved
Hide resolved
| var codeDocument = await context.GetCodeDocumentAsync(cancellationToken).ConfigureAwait(false); | ||
| var csharpDocument = codeDocument.GetCSharpDocument(); | ||
|
|
||
| return _documentSymbolService.GetDocumentSymbols(context.Uri, csharpDocument, csharpSymbols); | ||
| } | ||
|
|
||
| [return: NotNullIfNotNull(nameof(roslynDocumentSymbols))] |
There was a problem hiding this comment.
I don't think DocumentSymbol[]? is right for the signature. TryGetFirst on SumType<DocumentSymbol[], SymbolInformation[]> should guarantee a non-null value I think
There was a problem hiding this comment.
Thats true, but this method is called recursively for the Children property, which is nullable. I guess I can handle the null for that inline though. Seems a bit nicer :)
…VSCodeDocSymbol # Conflicts: # src/Razor/src/Microsoft.CodeAnalysis.Razor.CohostingShared/Microsoft.CodeAnalysis.Razor.CohostingShared.projitems
This was referenced Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a serialization problem that broke this in VS, when we went to Roslyn LSP types. This one is extra cool because it's still a very low effort port to VS Code, but we previously didn't support document symbols in VS Code at all. Chasing parity while also leapfrogging? 😁
Part of #11759