Add VS Code IMappingService #11760
Merged
Add VS Code IMappingService #11760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
had endpoints but some of the information that is easy to map, for example range -> span, is harder to do gracefully in typescript. This updates some of those endpoints to add information needed and adds an exported DocumentService for VS Code. This can be used independent of Roslyn/VSCode-CSharp changes but those will be needed to fully light this up
ryzngard
commented
Apr 22, 2025
...or/src/Microsoft.AspNetCore.Razor.LanguageServer/Mapping/RazorMapToDocumentRangesEndpoint.cs
Show resolved
Hide resolved
davidwengier
approved these changes
Apr 22, 2025
...crosoft.CodeAnalysis.Razor.Workspaces/Protocol/DocumentMapping/RazorMapDynamicSpansParams.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudioCode.RazorExtension/Services/MappingService.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudioCode.RazorExtension/Services/MappingService.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudioCode.RazorExtension/Services/MappingService.cs
Outdated
Show resolved
Hide resolved
...crosoft.CodeAnalysis.Razor.Workspaces/Protocol/DocumentMapping/RazorMapDynamicSpansParams.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudioCode.RazorExtension/Services/MappingService.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudioCode.RazorExtension/Services/MappingService.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudioCode.RazorExtension/Services/RazorMapSpansParams.cs
Outdated
Show resolved
Hide resolved
...or/src/Microsoft.AspNetCore.Razor.LanguageServer/Mapping/RazorMapToDocumentRangesEndpoint.cs
Show resolved
Hide resolved
Co-authored-by: Dustin Campbell <dustin@teamcampbell.org>
…razor into vscode_mapping_service
DustinCampbell
approved these changes
Apr 24, 2025
This was referenced Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an LSP mapping service that can be used in VS Code. We previously
had endpoints but some of the information that is easy to map, for
example range -> span, is harder to do gracefully in typescript. This
updates some of those endpoints to add information needed and adds an
exported DocumentService for VS Code.
This can be used independent of Roslyn/VSCode-CSharp changes but those
will be needed to fully light this up