Skip to content

Conversation

@ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Dec 3, 2024

Razor side of dotnet/roslyn#76050

@ryzngard ryzngard requested a review from a team as a code owner December 3, 2024 03:33
Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there changes needed on the Razor side to get the full text of the generated file? Or is that being handled all from TypeScript?

@ryzngard
Copy link
Contributor Author

ryzngard commented Dec 3, 2024

Is there changes needed on the Razor side to get the full text of the generated file? Or is that being handled all from TypeScript?

Typescript is the final place for now. It still has a copy of the edits/final text. We could forward back and forth but there's more work on the publication side for that to do. Maybe a good follow up once the system is proven out

@davidwengier
Copy link
Member

It feels weird not having the source of truth be the LSP server, because if the checksums fail, how can we trust that TypeScript has a true representation of the file, but at the same time it should be a rare thing so hopefully shouldn't be needed at all. I'm fine with this to start.

@ryzngard
Copy link
Contributor Author

ryzngard commented Dec 3, 2024

It feels weird not having the source of truth be the LSP server, because if the checksums fail, how can we trust that TypeScript has a true representation of the file, but at the same time it should be a rare thing so hopefully shouldn't be needed at all. I'm fine with this to start.

Yea. I think this is proving out the overall architecture. One change to make the LSP the source of truth is a separate gutting change. Right now the typescript is the source of truth anyways.

I do think that's the logical next step though and should simplify things farther

@ryzngard ryzngard merged commit a961d10 into dotnet:main Dec 4, 2024
12 checks passed
@ryzngard ryzngard deleted the dynamic_file_changes branch December 4, 2024 21:04
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 4, 2024
@jjonescz jjonescz modified the milestones: Next, 17.13 P3 Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants