Fix find all references calls to Roslyn #10807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@phil-allen-msft Another for 17.12 Preview 2, as that is where the Roslyn PR that broke us went. All Find All References commands from inside a Razor file are broken without this fix. |
phil-allen-msft
approved these changes
Aug 28, 2024
davidwengier
added a commit
to davidwengier/razor
that referenced
this pull request
Sep 6, 2024
This should have been fixed with dotnet#10807 but without the Roslyn bump I guess I didn't realise. Oops!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes integration test failures in Find All References.
Roslyns LSP types got much more spec compliant in dotnet/roslyn#73911 and we were never sending the
Contextproperty in our request, so deserialization failed on their end.