Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow LSP and cohosting to provide specialized methods to get a syntax tree #10765

Merged
merged 8 commits into from
Aug 21, 2024

Commits on Aug 20, 2024

  1. Allow LSP and cohosting to provide specialized methods to get a synta…

    …x tree for a C# document
    davidwengier committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    efceb90 View commit details
    Browse the repository at this point in the history
  2. Defer to C# for component attribute GTD in cohosting

    This was a subtle future bug, that we would have hit when we removed the C# syntax tree bits in future. By checking for Razor GTD first we weren't deferring to Roslyn for plain attributes (ie, the case without `@bind-` in the tests) which means at best we do some extra unnecessary work, and at worst we could lose features for things Roslyn supports but we don't.
    
    I did not intend to find this bug when I started. Sorry for missing it in the PR Dustin. The key is that `ignoreAttributes` should have been `true` when porting over the code, and changing that would have made the test fail in your branch.
    davidwengier committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5ef490f View commit details
    Browse the repository at this point in the history
  3. Add missing test case

    davidwengier committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ad16b16 View commit details
    Browse the repository at this point in the history
  4. Directly test the component definition service in cohosting

    See comment in the file, but essentially this is the only way for the code that returns the generated documents syntax tree to be hit in cohosting.
    davidwengier committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    a8b4259 View commit details
    Browse the repository at this point in the history
  5. Rework how we get generated documents

    In light of "should we get rid of document context" convo this morning, figured this made sense to do (and I needed _something_ on IDocumentSnapshot in order to actually make this whole idea work)
    davidwengier committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7470352 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7d5b206 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    53fec86 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    a3edec0 View commit details
    Browse the repository at this point in the history