Fix attribute parsing recovery #10620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
approved these changes
Jul 17, 2024
DustinCampbell
approved these changes
Jul 18, 2024
src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Legacy/HtmlMarkupParser.cs
Outdated
Show resolved
Hide resolved
chsienki
approved these changes
Jul 18, 2024
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10586.
When a C# expression or a razor comment is encountered while parsing attributes, a recovery mode is entered but usually exited only at the end of the tag. That leads to parsing the remaining attributes inconsistently (the emitted code still usually works, but has a different codegen leading to the bug).
This PR changes that to parse C# expressions and razor comments and then exit the recovery mode and continue parsing attributes normally.
Note that this is not specific to conditional attributes per se but they best demonstrate the bug because in recovery mode they emit
Write(null)whereas normally they emitWriteAttributeValue(null)which behaves differently (the latter omits the whole attribute).This is also not a problem in Blazor components, they do not allow C# or razor comments in them, the
@is not a transition there but simply part of the attribute name (used for special attributes like@ref).Commit-by-commit review might be useful.