Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused field #9563

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Remove unused field #9563

merged 1 commit into from
Oct 18, 2024

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Oct 17, 2024

The base class does exactly the same logic as this class. Doing this here adds a little size to the object (not a big deal) and is potentially confusing (a bigger deal).

Microsoft Reviewers: Open in CodeFlow

The base class does exactly the same logic as this class. Doing this here adds a little size to the object (not a big deal) and is potentially confusing (a bigger deal).
@drewnoakes drewnoakes added the Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support. label Oct 17, 2024
@drewnoakes drewnoakes requested a review from a team as a code owner October 17, 2024 23:28
@drewnoakes drewnoakes merged commit 7abba98 into dotnet:main Oct 18, 2024
5 checks passed
@drewnoakes drewnoakes deleted the remove-field branch October 18, 2024 20:45
@dotnet-policy-service dotnet-policy-service bot added this to the 17.12 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-NuGet NuGet integration including pushing it properties, project and package references, and Pack support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants