Fail FUTDC when output ref assembly missing #9558
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A project's reference assembly output has historically been ignored by its FUTDC. The file cannot be treated as a standard output, as it is not always changed in response to input changes. Treating it as a regular output would therefore lead to overbuild. This change adds explicit handling for the file, so that if it is removed from disk then the FUTDC consider the project out-of-date, and a build is scheduled.
drewnoakes
added
the
Feature-Up-to-date
|
Creating this as a draft PR because I want to take some time to consider the direction here. This was reported by @lifengl on Teams as part of a larger scenario, and I'm not sure that this change is generally helpful in isolation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9557
A project's reference assembly output has historically been ignored by its FUTDC. The file cannot be treated as a standard output, as it is not always changed in response to input changes. Treating it as a regular output would therefore lead to overbuild.
This change adds explicit handling for the file, so that if it is removed from disk then the FUTDC consider the project out-of-date, and a build is scheduled.
Microsoft Reviewers: Open in CodeFlow