Skip to content

Conversation

@drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Feb 28, 2023

Fixes #8880

Build acceleration works best when all referenced projects produce a reference assembly each. We recently added a message highlighting when this was not the case, but didn't explain which project needed to be modified in order to fix this issue.

This change tracks and logs which projects need updating. The TargetPath is printed for those projects, which will generally also identify the target framework and so is therefore more helpful than just the .csproj file.

Microsoft Reviewers: Open in CodeFlow

Build acceleration works best when all referenced projects produce a reference assembly each. We recently added a message highlighting when this was not the case, but didn't explain which project needed to be modified in order to fix this issue.

This change tracks and logs which projects need updating. The TargetPath is printed for those projects, which will generally also identify the target framework and so is therefore more helpful than just the .csproj file.
@drewnoakes drewnoakes added Tenet-User Friendly This issue affects the "User Friendly" tenet; UI usability, accessibility or high-DPI related. Feature-Build-Acceleration Build Acceleration can skip calls to MSBuild within Visual Studio labels Feb 28, 2023
@drewnoakes drewnoakes added this to the 17.6 milestone Feb 28, 2023
@drewnoakes drewnoakes requested a review from a team as a code owner February 28, 2023 09:19
Copy link
Member

@haileymck haileymck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@drewnoakes drewnoakes merged commit 436bc57 into dotnet:main Mar 1, 2023
@drewnoakes drewnoakes deleted the log-projects-not-producing-ref-assembly branch March 1, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature-Build-Acceleration Build Acceleration can skip calls to MSBuild within Visual Studio Tenet-User Friendly This issue affects the "User Friendly" tenet; UI usability, accessibility or high-DPI related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build acceleration log should include name of project(s) not using ProduceReferenceAssembly

3 participants