VS and msbuild spinning constantly in recent drop

[CyrusNajmabadi]

I've upgraded to:

I'm finding huge swaths of time when both VS and msbuild are just spinning at least two full cores of my machine. This is especially bad since this is a laptop and it drains the battery significantly while this is happening.

ETL can be found here: https://drive.google.com/file/d/0ByISdSEZ09PBbVp0enRzSVNhZVk/view?usp=sharing

[CyrusNajmabadi]

Tagging @davkean

[davkean]

@CyrusNajmabadi I'll look at this today.

[davkean]

Can you give me the exact commit that you are sync'd against?

[davkean]

Haven't figured out what's going on yet (I suspect we're constantly reevaluation due to a restore loop), but 16% of all the time here is spent on a GetFileAttributesEx check in the DiagnosticIncrementalAnalyzer that seems a lot:

[davkean]

I'm not seeing this on 46709.0.d15rel. I do see lots of MSBuild instances and us chewing CPU for a few minutes, but this looks like us doing design-time builds but we eventually stop.

@CyrusNajmabadi If you leave it VS open for 10 minutes, does the CPU stop?

[CyrusNajmabadi]

Probably yes. But then i use the product and these things spin up again. Effectively, as long as i'm using VS i'm seeing these issues unendingly.

[davkean]

@CyrusNajmabadi What kinds of changes? If you add, remove or rename a source file then this is going to cause us to reevaluate and spawn MSBuild.

[CyrusNajmabadi]

Just editing. Perhaps a file change a few times an hour. VS is behaving exceptionally poorly from startup till shutdown. When it gets particularly bad (i.e. i can't even function and deal with the constant few-second ui hangs), i take these traces and report the issues.

[davkean]

@CyrusNajmabadi Okay, but I'm trying to figure out if those issues are different to this issue or not. This issue says you have constant CPU and MSBuild constantly - I'm trying to figure out if you are actually experiencing a constant CPU when you aren't making changes or whether the perf issues are result of something else, such as this one: #2579.

[CyrusNajmabadi]

Ok. so as an example, i was just editing right now and i lost all intellisense. I looked and my file had moved into the misc workspace. So i tried to close VS. It just hung there. The hang was so long that i went and collected a trace. I will upload that now.

[CyrusNajmabadi]

Closing VS trace: https://drive.google.com/file/d/0ByISdSEZ09PBUF9pSy1wQXNHZTQ/view?usp=sharing
MSBuild spinning trace: https://drive.google.com/file/d/0ByISdSEZ09PBVmVCQ3AzdUdjOEU/view?usp=sharing